Repository navigation
Conversation
- `poissonBracket`, antisymmetry, bilinearity in each argument, and `deriv_comp_eq_poissonBracket` connecting it to time evolution under Hamilton's equations. - `gradient_add` in `Physlib.Mathematics.Calculus.Gradient`, the missing additivity rule needed to prove bilinearity. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `poissonBracket_self`, the Poisson bracket of a function with itself vanishes, and `poissonBracket_eq_of_hasGradientAt`, the bracket of two functions with known partial gradients. - `LiouvilleIntegrableOn U H`, a Hamiltonian system with `d` smooth conserved quantities, one of them the Hamiltonian, which are in involution and functionally independent on an open dense domain `U` of phase space. - `LiouvilleIntegrableOn.deriv_comp_eq_zero`, each conserved quantity is constant along a solution of Hamilton's equations in `U`. - `LiouvilleIntegrableOn.oneDegreeOfFreedom`, a system with one degree of freedom is Liouville integrable wherever its Hamiltonian is smooth with non-vanishing gradient. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `HasGradientAt.add`, `HasGradientAt.sub`, `HasGradientAt.mul`, `HasGradientAt.const_mul`, the algebraic rules for gradients. - `HasDerivAt.comp_hasGradientAt`, the chain rule for a real function of a real-valued function. - `hasGradientAt_inner_left`, `hasGradientAt_inner_right`, `hasGradientAt_inner_self`, `hasGradientAt_norm`, `hasGradientAt_coord`, the gradients of scalar products, of the norm away from the origin, and of coordinate functionals on Euclidean space. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `CentralForce`, a particle in three dimensions under a central potential smooth away from the centre, with its `hamiltonian`. - `CentralForce.hasGradientAt_hamiltonian_momentum` and `CentralForce.hasGradientAt_hamiltonian_position`, the partial gradients of the Hamiltonian: the velocity `p / m`, and away from the centre a multiple of the position. - `CentralForce.contDiffOn_hamiltonian`, the Hamiltonian is smooth away from the centre of force. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `CentralForce.angularMomentum`, the angular momentum `q × p`, with
`angularMomentumSq` and `angularMomentumZ`, Lagrange's identity
`angularMomentumSq_eq`, their gradients and smoothness.
- `poissonBracket_angularMomentumSq_angularMomentumZ`, `{L², L_z} = 0`, and
`poissonBracket_angularMomentumSq_hamiltonian`,
`poissonBracket_angularMomentumZ_hamiltonian`, both are conserved under
a central force (via the `_eq_zero_of_hasGradientAt` versions for any
Hamiltonian with gradients parallel to `p` and `q`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `AnalyticOnNhd.dense_setOf_ne_zero`, by the identity principle a function analytic on a connected space and non-zero at some point is non-zero on a dense set. - `analyticAt_euclideanSpace_apply`, coordinate functionals on Euclidean space are analytic, tagged `fun_prop` so that polynomial functions of the coordinates are automatically analytic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `CentralForce.integrabilityDomain`, where the radial momentum is non-zero and the angular momentum is not parallel to the z-axis, with `isOpen_integrabilityDomain` and `dense_integrabilityDomain` (via the non-vanishing of an analytic polynomial). - `CentralForce.conservedQuantities`, the energy, `L²` and `L_z`, with `poissonBracket_conservedQuantities` (involution), `gradient_conservedQuantities`, `linearIndependent_gradients` and `linearIndependent_conservedQuantities` (functional independence). - `CentralForce.liouvilleIntegrable`, every central-force system is Liouville integrable on the domain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apply the analytic identity principle to the polynomial defining a central-force phase-space domain. Keep independence and the Liouville construction for a separate contribution. Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
Merge the small analytic-density application and current upstream APIs while preserving the original feature history. Keep this follow-up limited to the conserved quantities, their independence and the integrability construction. Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! While you wait for a review, note that you can review PRs too; reviewing is not restricted to maintainers. Our review guidelines explain what to look for. Over time, contributions such as reviews, maintenance and documentation are recorded on contributions.physlib.io. Three main points:
|
|
Maybe worth looking at this comment As I think this could form a better foundation for this, which makes the physics clearer |
|
See this #2003 |
|
awaiting-author For comments above |
|
Hi Joseph. Super sorry for the late reply, I was swamped with work. I'll take a look at this today, as I understand we're creating an API map that unifies foundational Hamiltonian mechanics ? If yes then that's great for me because I have a bunch of work locally relating to Hamiltonian structures, action angle variables etc. I'll read the lean docs on API maps later today and see how this contribution can be built on more solid footing. Sorry again for the late response :( |
|
@Sudo-RR No worries, but yes this is the idea. Would be great to have foundational Hamiltonian mechanics in so this sort of work can build on this. |
|
I have opened a PR for the Hamiltonian Mechanics API map. Once thats approved, I'll start refactoring the existing implementations to ensure that things follow from a unified structure. In similar spirit to Lagrangian mechanics. See #2025 |
Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
Co-authored-by: Claude Opus 4.8 <no-reply+claude-opus-4-8@anthropic.com>
|
Hi I think this PR is ready for review now :) I have modified it to use the shared structures I developed in the previous PR's. I.e. the Phase Space and Hamiltonian Structure PR's. |
|
jstoobysmith
left a comment
There was a problem hiding this comment.
Couple of comments, a number of which are structural.
| -/ | ||
| module | ||
|
|
||
| -- `Uniqueness` imports this module privately; the auxiliary analyticity lemmas need its public API. |
|
|
||
| /-- The coordinate functionals on Euclidean space are analytic. -/ | ||
| @[fun_prop] | ||
| lemma analyticAt_euclideanSpace_apply {𝕜 ι : Type*} [RCLike 𝕜] [Fintype ι] (i : ι) |
There was a problem hiding this comment.
What is the reason behind having this lemma? Seems like one could just use (EuclideanSpace.proj (𝕜 := 𝕜) i).analyticAt z in its place.
There was a problem hiding this comment.
Would move this too
PhyslibAlpha.ClassicalMechanics.CentralForce.LiouvilleIntegrable.lean
|
|
||
| /-- The three conserved quantities in involution of a central-force system: the Hamiltonian `H`, | ||
| the squared magnitude `L²` of the angular momentum, and its z-component `L_z`. -/ | ||
| noncomputable def conservedQuantities : |
There was a problem hiding this comment.
Should go in its own file I think within CentralForce
|
awaiting-author |
We establish that central-force systems are Liouville integrable on an open dense domain, where the Hamiltonian, squared angular momentum and its z-component are functionally independent and pairwise Poisson-commuting.
The domain excludes the centre of force, zero radial momentum, and angular momentum parallel to the z-axis.
This combines the analytic-density lemmas from #1838 with their physics application: proving that this domain is dense.